This repository was archived by the owner on Oct 27, 2020. It is now read-only.
fix(index): fallback to fs if this.fs is undefined
#45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for undefined `this.fs` when behind thread-loader
alexander-akait
approved these changes
Oct 30, 2018
michael-ciniawsky
changed the title
compiler's cached fs for stats if there, otherwise, fallbackfs if this.fs is undefined
michael-ciniawsky
suggested changes
Oct 30, 2018
Co-Authored-By: jsg2021 <[email protected]>
Co-Authored-By: jsg2021 <[email protected]>
Co-Authored-By: jsg2021 <[email protected]>
alexander-akait
suggested changes
Oct 30, 2018
src/index.js
Outdated
| // this.fs can be undefined | ||
| // e.g when using the thread-loader | ||
| // fallback to the fs module | ||
| const stat = this.fs ? this.fs.stat : fs.stat |
There was a problem hiding this comment.
The Apply Suggestion feature is pretty neat. :)
alexander-akait
approved these changes
Oct 30, 2018
|
No problem! :) |
|
I wrote up a concern in the larger issue: #43 (comment) |
Co-Authored-By: jsg2021 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #45 +/- ##
=========================================
- Coverage 17.47% 17.3% -0.17%
=========================================
Files 2 2
Lines 103 104 +1
Branches 13 14 +1
=========================================
Hits 18 18
Misses 73 73
- Partials 12 13 +1
Continue to review full report at Codecov.
|
michael-ciniawsky
added
status: Approved
and removed
pr_action: Review
priority: 3 (required)
severity: 3 (broken)
labels
|
Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes undefined
this.fswhen behind thread-loader